feat: Add support for manually specifiying gems for cross-repo.#149
Merged
varungandhi-src merged 3 commits intoscip-ruby/masterfrom Nov 4, 2022
Merged
feat: Add support for manually specifiying gems for cross-repo.#149varungandhi-src merged 3 commits intoscip-ruby/masterfrom
varungandhi-src merged 3 commits intoscip-ruby/masterfrom
Conversation
eb1b808 to
6a245ca
Compare
8 tasks
6a245ca to
3790e4b
Compare
Contributor
Author
|
Interesting; if I put a print statement inside https://github.com/sorbet/sorbet/tree/master/rbi/stdlib/yaml.rbi |
3790e4b to
b89f004
Compare
Contributor
Author
|
OK, so this does seem to be working OK for basic file lists, but the fallback to the |
b89f004 to
6c6d268
Compare
varungandhi-src
commented
Nov 4, 2022
3fa112c to
65d17ac
Compare
varungandhi-src
commented
Nov 4, 2022
varungandhi-src
commented
Nov 4, 2022
65d17ac to
57c8eac
Compare
57c8eac to
b1e47b0
Compare
varungandhi-src
commented
Nov 4, 2022
| end | ||
|
|
||
| sig { params(C, T::Boolean).returns(T::Boolean) } | ||
| # ^ reference [..] `T.untyped`# |
Contributor
Author
There was a problem hiding this comment.
Erm, why is this 'C' and not 'C1' and why are parameter types missing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This would help customers specify cross-repo mappings in an easy way
even when our inference fails.
Test plan
Add test for the stdlib version being used.We aren't using specific versions, we can add that later.